[pull] master from nvaccess:master #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
#17004) Closes #9101 Summary of the issue: The routing keys on a braille display do not work to move the text insertion point in Microsoft PowerPoint. Description of user facing changes The routing keys now move the cursor in PowerPoint. The review cursor selection commands also select text in text boxes. Description of development approach Looked at TextFrameTextInfo to look at how access to PowerPoint text works. Used the Microsoft Powerpoint Object Model documentation to find the appropriate methods. Implemented `_setCaretOffset` and `_setSelectionOffsets` methods on `appModules.powerpnt.TextFrameTextInfo`. --- Co-authored-by: Sean Budd <[email protected]>
Closes #16993 Summary of the issue: Multi-line braille displays using the HID standard driver only support the first line of cells. Description of user facing changes Users with multi-line braille displays that connect using the HidBrailleDriver will now be able to use all cells of their display. Description of development approach HidBrailleDriver._cellValueCaps is now a list of all braille cell controls in the device. numRows is set to the length of that list and numCols is set to the ReportCount of each element of the list. In display, the cells are split across the elements of _cellValueCaps.
Summary of the issue: The `tests/manual/createUpdatableAddons.ps1` script exists to expedite testing the add-on store. It provides defaults for addon name, NVDA config directory and addon major and minor versions. However, the default value for the config directory of an installed copy of NVDA is set incorrectly. Description of user facing changes None. This will only impact developers testing the add-on store. Description of development approach Updated `configFolder` to remove the `userData` subdirectory, which is not used in installed copies of NVDA. Testing strategy: Tested the script after the change to make sure it correctly updated the add-on store metadata and add-on manifest for the Clock add-on.
Summary of the issue: The contributing page is a list of central pages for different ways to contribute. Setting up a dev environment doesn't quite come under "a way to contribute" and is part of the above guide. Description of development approach Remove this.
Summary of the issue: pre-commit CI doesn't use a pinned version of python the pre-commit CI file is not validated by pre-commit pre-commit CI doesn't run our license check or unit tests. Further investigation was performed to see if this was possible. Unfortunately it is not. Description of user facing changes pin pre-commits python env version to 3.11 add validation for our pre-commit config with meta hooks expand notes on why unit testing and license check is not possible with pre-commit CI, there's no way to consistently having a matching python venv to local devs, and no custom telemetry.
Summary of the issue: NVDA dropped Windows 7 support with NVDA 2024.1. The installer should delete executables that were used by older versions of NVDA but which are now obsolete. However, this was not done for nvda_eoaProxy.exe, which existed to support Windows Vista/7 ease of access. Description of user facing changes None. Description of development approach Added nvda_eoaProxy.exe to the list of executables to be deleted by the installer.
nh3 0.2.18 This is a dependency update version with no functional changes.
) Fixes #16837 Summary of the issue: As reported by @CyrilleB79, if one were to update an add-on from the add-on store, then accept an NVDA update before restarting to complete the add-on update, the update will completely clobber the add-on. Upon further investigation, this is because the launcher erroneously attempts to complete add-on installation/removal, but an error is thrown (because it shouldn't be touching the file system) part way through, so it cannot complete successfully. Description of user facing changes If add-ons are pending installation/removal when an update is started, the installation will not affect this, and the installation/removal will proceed when the updated copy of NVDA starts. Description of development approach Added checks for NVDAState.shouldWriteToDisk() to sections of addonHandler._getAvailableAddonsFromPath that alter the filesystem.
Fixes #17026 Summary of the issue: Trying to compile NVDA with Visual Studio 2022 V17.11 produces the following error: build\x86\local\beeps.cpp(19): error C2039: 'min': is not a member of 'std' std::min and std::max are defined in <algorithm> which we never include in beeps.cpp. I assume that <cmath> used to include <algorithm> and now it does not. Description of user facing changes None. Description of development approach Include <algorithm> in beeps.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )