Skip to content

Update install-eventing-with-yaml.md #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

mwmahlberg
Copy link
Contributor

File is named eventing-jsm.yaml in v1.18.0

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

  • None. I assume this simply to be an oversight while renaming the release file

File is named eventing-jsm.yaml in v1.18.0
Copy link

linux-foundation-easycla bot commented May 11, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from dsimansk and skonto May 11, 2025 11:30
Copy link

netlify bot commented May 11, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 968b0fc
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/68208a510deceb0008b7c694
😎 Deploy Preview https://deploy-preview-6269--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

knative-prow bot commented May 11, 2025

Welcome @mwmahlberg! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2025
@dprotaso
Copy link
Member

/ok-to-test

/lgtm
/approve
/cherry-pick release-1.18

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 13, 2025
@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

In response to this:

/ok-to-test

/lgtm
/approve
/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@dprotaso
Copy link
Member

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mwmahlberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@knative-prow knative-prow bot merged commit 092cec1 into knative:main May 13, 2025
18 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6270

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6271

In response to this:

/ok-to-test

/lgtm
/approve
/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants