Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(submissions): avoid adding XML declaration when rewriting submission XML and creating asset snapshot #5439

Merged

Conversation

rajpatel24
Copy link
Contributor

📣 Summary

The clean_duplicated_submissions command has been updated to save XML files without the declaration.

📖 Description

This update modifies the behavior of the clean_duplicated_submissions command to save XML files without including the declaration. This change ensures cleaner XML outputs by removing unnecessary declaration headers, making it easier to work with the files programmatically.

@rajpatel24 rajpatel24 removed the request for review from jnm January 23, 2025 08:04
@rajpatel24 rajpatel24 changed the title Update clean_duplicated_submissions command to save XML without declaration Update clean_duplicated_submissions command to save XML without declaration and update snapshot Jan 23, 2025
@rajpatel24 rajpatel24 self-assigned this Jan 23, 2025
@noliveleger noliveleger changed the title Update clean_duplicated_submissions command to save XML without declaration and update snapshot fix(submissions): avoid adding XML declaration when rewriting submission XML and creating asset snapshot Jan 23, 2025
@rajpatel24 rajpatel24 force-pushed the update_clean_duplicated_submissions_management_command branch from 5edeb3d to 6436a9c Compare January 23, 2025 18:50
@rajpatel24 rajpatel24 force-pushed the update_clean_duplicated_submissions_management_command branch from 6436a9c to f1afa4e Compare January 23, 2025 18:56
Copy link
Contributor

@noliveleger noliveleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noliveleger noliveleger changed the base branch from main to release/2.025.02 January 23, 2025 20:49
@noliveleger noliveleger changed the base branch from release/2.025.02 to main January 23, 2025 20:49
@noliveleger noliveleger requested review from noliveleger and removed request for rgraber, jamesrkiger and magicznyleszek January 23, 2025 20:49
@rajpatel24 rajpatel24 merged commit 4d59d72 into main Jan 27, 2025
4 checks passed
@rajpatel24 rajpatel24 deleted the update_clean_duplicated_submissions_management_command branch January 27, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants