Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(billing): require org id for service/asset usage TASK-1476 #5443

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Jan 23, 2025

πŸ—’οΈ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

πŸ“£ Summary

Removes option for API calls to retrieve user-based service/asset usage.

πŸ’­ Notes

We previously allowed for the possibility that users would not be organization members. If a user wasn't an org member, we used a separate API endpoint to retrieve their usage data. Now, however, from a frontend perspective users are always organization members and we should always use the organization usage endpoints.

πŸ‘€ Preview steps

  1. As a member of an MMO with at least one admin member, create and deploy a project and make a submission.
  2. Access the organization usage page as an admin and view the per-project usage table.
  3. On main, this table will be empty. On this PR branch, it will include the project.
  4. Access the organization usage page as the owner and view the per-project usage table.
  5. On main, the project will be shown as a draft. On this branch it will show up as deployed.

Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesrkiger jamesrkiger merged commit 0fc340b into main Jan 24, 2025
7 checks passed
@jamesrkiger jamesrkiger deleted the task-1476-require-organization-usage-calls branch January 24, 2025 14:55
rajpatel24 pushed a commit that referenced this pull request Jan 28, 2025
### πŸ“£ Summary
Removes option for API calls to retrieve user-based service/asset usage.

### πŸ’­ Notes
We previously allowed for the possibility that users would not be
organization members. If a user wasn't an org member, we used a separate
API endpoint to retrieve their usage data. Now, however, from a frontend
perspective users are always organization members and we should always
use the organization usage endpoints.


### πŸ‘€ Preview steps
1. As a member of an MMO with at least one admin member, create and
deploy a project and make a submission.
2. Access the organization usage page as an admin and view the
per-project usage table.
3. On main, this table will be empty. On this PR branch, it will include
the project.
4. Access the organization usage page as the owner and view the
per-project usage table.
5. On main, the project will be shown as a draft. On this branch it will
show up as deployed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants