fix(translations): use trimmed in all blocktrans blocks TASK-1553 #5527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234
frontend
orbackend
unless it's global📖 Description
Developer-only changes
💭 Notes
This was done with a simple find-and-replace. To test it, I compiled the messages and ran
find . -name django.po | xargs awk '{ if (lastline == "msgid \"\"" && $0 ~ "\"\\\\n\"") {print FILENAME, $0} {lastline=$0}}' | wc -l
and checked to make sure the output was empty.The
awk
command looks for sections of a .po file that look like, which is what it looks like when a translation string begins with a newline char. The full command lists all po files, checks for that sequence of lines using
awk
for each one, and counts the total. On main, the count was 257. Using this branch, the count is 2. It should be 0, but for some reasonmakemessages
had trouble withzh-Hant
andzh-Hans
so it didn't actually update those files. That doesn't matter for this PR.👀 Preview steps
python ./manage makemessages -a
locale
directory inside kpifind . -name django.po | xargs awk '{ if (lastline == "msgid \"\"" && $0 ~ "\"\\\\n\"") {print FILENAME, $0} {lastline=$0}}' | wc -l