refactor(organization): use unique email template names #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajpatel24
approved these changes
Feb 18, 2025
rajpatel24
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Ensured email template names are unique to prevent conflicts between closely related Django apps.
📖 Description
When two Django apps use the same email template name and are closely linked, Django does not differentiate between them and selects the first template it finds in the filesystem hierarchy. This can lead to inconsistencies in email rendering, where the wrong template is used depending on the directory structure.
This refactor resolves the issue by ensuring that all email template names are unique across apps, preventing unintended overrides and ensuring the correct template is always used.