fix(invitations): hide invitation accepted banner for users who are no longer members of organization TASK-1585 #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicznyleszek
deleted the
leszek/task-1585-hide-banner-for-removed-org-member
branch
rgraber
pushed a commit
that referenced
this pull request
Feb 18, 2025
…o longer members of organization TASK-1585 (#5532) ### 💭 Notes I've renamed `showBanner` to `isBannerDismissed` for clarity and improved the `if`s list. The actual fix is verifying `orgQuery.data.is_mmo`. ### 👀 Preview steps Bug template: 1. ℹ️ have two accounts: "joe" and "bo"; "joe" is org owner, "bo" is not 2. send invite from "joe" to "bo" for joining organization 3. accept invite as "bo" (mind https://www.notion.so/kobotoolbox/Display-invite-accepted-banner-immediately-19d7e515f6548087afedf3644410c72d?pvs=4) 4. 🟢 as "bo" notice that the invite accepted banner shows up (on top of `/#/projects/home` route) (make sure not to dismiss the banner with "x" button) 5. as "joe" then remove "bo" from organization 6. 🔴 [on main] as "bo" notice that the banner is still visible 7. 🟢 [on PR] as "bo" notice that the banner is not visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 Notes
I've renamed
showBannertoisBannerDismissedfor clarity and improved theifs list. The actual fix is verifyingorgQuery.data.is_mmo.👀 Preview steps
Bug template:
/#/projects/homeroute) (make sure not to dismiss the banner with "x" button)