fix(billing): billing period detection for end-of-month cancellations #5533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Fixed an issue where the billing period was incorrectly detected for end-of-month cancellations.
📖 Description
The billing period detection logic has been updated to align with Stripe's methodology for handling end-of-month cancellations. Previously, the system did not fully follow Stripe's approach when determining the final billing period, which could lead to inconsistencies in how the cancellation date was interpreted.
💭 Notes
Backport of #5524 and supersedes it.
@jamesrkiger already reviewed #5524 and approved it.