Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): use toast instead of alertify #5546

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Feb 20, 2025

💭 Notes

Mistakingly import { notify } from 'alertifyjs' was being used instead of import { notify } from 'js/utils'. I've added some deprecation tags to alertify related code. Note that our notify (it uses react-hot-toast) might get deprecated soon too - in favor of Mantine's notifications system.

👀 Preview steps

Bug template:

  1. ℹ️ have two accounts: "joe" and "bo"; "joe" is org owner, "bo" is not
  2. send invite from "joe" to "bo" for joining joe's organization
  3. remove invitation
  4. 🔴 [on main] notice that the notification appears in bottom right corner and it looks different
  5. 🟢 [on PR] notice that the notification appears in top center and it looks as it should :)

@magicznyleszek magicznyleszek self-assigned this Feb 20, 2025
@magicznyleszek magicznyleszek marked this pull request as ready for review February 20, 2025 12:22
@magicznyleszek magicznyleszek merged commit bae9f04 into main Feb 20, 2025
5 checks passed
@magicznyleszek magicznyleszek deleted the leszek/fix-wrong-toasts-being-used branch February 20, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant