Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(organizations): adjust loading process for invite responses TASK-1602 #5547

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Feb 20, 2025

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

Introduces a delay in refreshing user data after an MMO invitation is accepted to allow for initial backend project transfers and separates the loading state of the accept/decline buttons.

💭 Notes

Combines work for both TASK-1602 and TASK-1603. The impacted code is closely related and it will be quicker to preview/test both at the same time.

👀 Preview steps

  1. As an MMO owner/admin invite a new member to organization

  2. As invitee, navigate to emailed invitation link

  3. Decline invite (you might want to throttle your network connection in devtools first for easier observation)

  4. Observe that only the "decline" button loading spinner is activated

  5. As an MMO owner/admin invite a new member to organization

  6. As invitee, create an empty project ("invitee's project")

  7. navigate to emailed invitation link

  8. Accept invite (you might want to throttle your network connection in devtools first for easier observation)

  9. Observe that only the "Accept" button loading spinner is activated

  10. Observe that once invitation patch has been successful, the modal displays a loading spinner for 1 second before disappearing, following which session and project list data are refreshed (with a loading spinner on the data table) and "invitee's project" is now shown to belong to MMO

@jamesrkiger jamesrkiger requested review from pauloamorimbr and removed request for magicznyleszek February 20, 2025 15:52
Copy link
Contributor

@pauloamorimbr pauloamorimbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

From all I've tested it's working as it should. Codewise looks good as well.

Not related to this PR though, I believe we should remove the closing when click outside and the close button from the modal, so we can force the user to either accept or decline the invitation, since just closing the modal won't trigger a choice.

Also..it happened to me some times when testing to click the browser to set focus to it after looking at some logs causing the modal to close, because I clicked outside of it. In some cases that might be a reason for the user to miss the modal completely. (i.e: click the email, while it's loading click on some other thing and then click back in the browser, closing the modal)

@jamesrkiger jamesrkiger merged commit dd60d08 into main Feb 21, 2025
5 checks passed
@jamesrkiger jamesrkiger deleted the task-1602-invite-data-refresh-delay branch February 21, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants