improve speed of allunique (JuliaLang#37208)

koekjesdoos · Aug 27, 2020 · f8a73da · f8a73da
1 parent 701885b
commit f8a73da
Showing 1 changed file with 18 additions and 7 deletions.
diff --git a/base/set.jl b/base/set.jl
@@ -382,15 +382,26 @@ false
 ```
 """
 function allunique(C)
-    seen = Set{eltype(C)}()
-    for x in C
-        if in(x, seen)
-            return false
-        else
-            push!(seen, x)
+    seen = Dict{eltype(C), Nothing}()
+    x = iterate(C)
+    if haslength(C) && length(C) > 1000
+        for i in OneTo(1000)
+            v, s = x
+            idx = ht_keyindex2!(seen, v)
+            idx > 0 && return false
+            _setindex!(seen, nothing, v, -idx)
+            x = iterate(C, s)
         end
+        sizehint!(seen, length(C))
+    end
+    while x !== nothing
+        v, s = x
+        idx = ht_keyindex2!(seen, v)
+        idx > 0 && return false
+        _setindex!(seen, nothing, v, -idx)
+        x = iterate(C, s)
     end
-    true
+    return true
 end
 
 allunique(::Union{AbstractSet,AbstractDict}) = true