Skip to content

Commit

Permalink
sunrpc: simplify two-level sysctl registration for svcrdma_parm_table
Browse files Browse the repository at this point in the history
There is no need to declare two tables to just create directories,
this can be easily be done with a prefix path with register_sysctl().

Simplify this registration.

Signed-off-by: Luis Chamberlain <[email protected]>
Reviewed-by: Jeff Layton <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
  • Loading branch information
mcgrof authored and chucklever committed Apr 26, 2023
1 parent cf64b9b commit 376bcd9
Showing 1 changed file with 2 additions and 19 deletions.
21 changes: 2 additions & 19 deletions net/sunrpc/xprtrdma/svc_rdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,24 +212,6 @@ static struct ctl_table svcrdma_parm_table[] = {
{ },
};

static struct ctl_table svcrdma_table[] = {
{
.procname = "svc_rdma",
.mode = 0555,
.child = svcrdma_parm_table
},
{ },
};

static struct ctl_table svcrdma_root_table[] = {
{
.procname = "sunrpc",
.mode = 0555,
.child = svcrdma_table
},
{ },
};

static void svc_rdma_proc_cleanup(void)
{
if (!svcrdma_table_header)
Expand Down Expand Up @@ -263,7 +245,8 @@ static int svc_rdma_proc_init(void)
if (rc)
goto out_err;

svcrdma_table_header = register_sysctl_table(svcrdma_root_table);
svcrdma_table_header = register_sysctl("sunrpc/svc_rdma",
svcrdma_parm_table);
return 0;

out_err:
Expand Down

0 comments on commit 376bcd9

Please sign in to comment.