Chore: Warn on PR with lock file changes

konradk · Nov 24, 2017 · 49da1c4 · 49da1c4
1 parent 04989d3
commit 49da1c4
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/dangerfile.js b/dangerfile.js
@@ -2,8 +2,15 @@ import { danger, warn } from 'danger';
 
 const packageChanged = danger.git.modified_files.includes('package.json');
 const lockfileChanged = danger.git.modified_files.includes('package-lock.json');
+
 if (packageChanged && !lockfileChanged) {
-	warn(`Changes were made to package.json, but not to package-lock.json.
+	warn(`Changes were made to \`package.json\`, but not to \`package-lock.json\`.
+
+Perhaps you need to run \`npm install\` and commit changes in package-lock.json. Make sure you’re using npm 5+.`);
+}
+
+if (!packageChanged && lockfileChanged) {
+	warn(`Changes were made to \`package-lock.json\`, but not to \`package.json\`.
 
-Perhaps you need to run \`npm install\` and commit changes in package-lock.json.. Make sure you’re using npm 5+.`);
+Please remove \`package-lock.json\` changes from your pull request. Try to run \`git checkout master -- package-lock.json\` and commit changes.`);
 }