cmake: check_compiler_flag: Fix bug where checks were aliased

Fix a bug where different compiler checks were aliased and therefore
the test results were incorrectly re-used.

The 'check' string is used by CMake internally to cache test results,
but when testing linker flags the check string has been aliased
between the different linker checks. To fix the aliasing issue we add
the CMAKE_REQUIRED_FLAGS variable to the 'check' string. The aliasing
issue disappears because the linker flag-under-test is in
'CMAKE_REQUIRED_FLAGS'.

Signed-off-by: Sebastian Bøe <[email protected]>

cmake/extensions.cmake

@@ -943,7 +943,11 @@ endfunction()
 # check_compiler_flag(C "-Wall" my_check)
 # print(my_check) # my_check is now 1
 function(check_compiler_flag lang option ok)
-  string(MAKE_C_IDENTIFIER check${option}_${lang} ${ok})
+
+  string(MAKE_C_IDENTIFIER
+    check${option}_${lang}_${CMAKE_REQUIRED_FLAGS}
+    ${ok}
+    )
 
   if(${lang} STREQUAL C)
     check_c_compiler_flag("${option}" ${${ok}})