changed clap to arghs in examples #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarriba
requested changes
Mar 18, 2025
| @@ -12,34 +12,32 @@ use ort::session::Session; | |||
| /// Represents a detected object in an image. | |||
| #[derive(Debug)] | |||
| pub struct Detection { | |||
| /// The class label of the detected object. | |||
| struct Args { | ||
| #[arg(short, long)] | ||
| #[argh(option, short = 'i', long = "image_path")] |
There was a problem hiding this comment.
Suggested change
| #[argh(option, short = 'i', long = "image_path")] | |
| #[argh(option, short = 'i')] |
no sense to add this if it's the same as the member itself
| @@ -13,6 +13,6 @@ version.workspace = true | |||
| publish = false | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "4.5.9", features = ["derive"] } | |||
| arghs = "0.1.7" | |||
There was a problem hiding this comment.
please add once in the root workspace
| @@ -123,8 +119,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| println!("out_tensor: {:?}", out_tensor.shape); | |||
|
|
|||
| // parse the output tensor | |||
| // we expect the output tensor to be a tensor of shape [1, 300, 6] | |||
| @@ -7,7 +7,7 @@ edition = "2021" | |||
| publish = false | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "4.5.4", features = ["derive"] } | |||
| args = "1.0.0" # Replace with the appropriate version for args | |||
| @@ -13,7 +13,7 @@ version.workspace = true | |||
| publish = false | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "4.5.9", features = ["derive"] } | |||
| args = "1.0" # Replace with the appropriate version for args | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the files in the "examples" directory to"argh" library