Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation decorator from depth_to_3d function #3142

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

Incharajayaram
Copy link
Contributor

@Incharajayaram Incharajayaram commented Mar 15, 2025

Changes

This PR removes the deprecation decorator from the depth_to_3d function to address issue #3015. Currently, depth_to_normals uses depth_to_3d, which is marked as deprecated, causing users to see deprecation warnings when using depth_to_normals. Since depth_to_3d_v2 is not a direct replacement due to different tensor dimension ordering, this PR removes the deprecation warning until a proper transition can be implemented.
Fixes #3015

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@edgarriba edgarriba requested review from johnnv1 and ducha-aiki March 17, 2025 09:54
@johnnv1 johnnv1 merged commit 5729688 into kornia:main Mar 22, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depth_to_normals spams deprecation warning
3 participants