fix(web): use missing umdName option in package builder

kpaxton · Aug 7, 2020 · fdab3b9 · fdab3b9
1 parent 757bce7
commit fdab3b9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/.cz-config.js b/.cz-config.js
@@ -24,6 +24,7 @@ module.exports = {
     { name: 'node', description: 'anything Node specific' },
     { name: 'nx-plugin', description: 'anything Nx Plugin specific' },
     { name: 'react', description: 'anything React specific' },
+    { name: 'web', description: 'anything Web specific' },
     { name: 'linter', description: 'anything Linter specific' },
     { name: 'storybook', description: 'anything Storybook specific' },
     {

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -170,6 +170,7 @@ The scope must be one of the following:
 - node - anything Node specific
 - linter - anything Linter specific
 - react - anything React specific
+- web - anything Web specific
 - storybook - anything Storybook specific
 - testing - anything testing specific (e.g., jest or cypress)
 - repo - anything related to managing the repo itself

diff --git a/packages/web/src/builders/package/package.impl.ts b/packages/web/src/builders/package/package.impl.ts
@@ -237,7 +237,7 @@ export function createRollupOptions(
         globals,
         format: config.format,
         file: `${options.outputPath}/${context.target.project}.${config.extension}.js`,
-        name: toClassName(context.target.project),
+        name: options.umdName || toClassName(context.target.project),
       },
       external: (id) => externalPackages.includes(id),
       plugins,

diff --git a/packages/web/src/utils/types.ts b/packages/web/src/utils/types.ts
@@ -58,6 +58,7 @@ export interface PackageBuilderOptions {
   watch?: boolean;
   assets?: any[];
   updateBuildableProjectDepsInPackageJson?: boolean;
+  umdName?: string;
 }
 
 export interface AssetGlobPattern extends JsonObject {