Skip to content

Commit

Permalink
Make upb compatible with --incompatible_disallow_empty_glob
Browse files Browse the repository at this point in the history
This will allow us to run all the upb tests from the protobuf repo, which
already uses this flag. I just had to remove a couple glob patterns that did
not match any files.

PiperOrigin-RevId: 559434154
  • Loading branch information
acozzette authored and copybara-github committed Aug 23, 2023
1 parent 94c4c32 commit 00efe9f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ build --features=-debug_prefix_map_pwd_is_dot
build --cxxopt=-std=c++17 --host_cxxopt=-std=c++17
build:cpp17_msvc --cxxopt=/std:c++17 --host_cxxopt=/std:c++17

# Disallow empty globs
build: --incompatible_disallow_empty_glob

# Use our custom-configured c++ toolchain.

build:m32 --copt=-m32 --linkopt=-m32
Expand Down
1 change: 0 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,6 @@ filegroup(
"upb/**/*.c",
"upb/**/*.h",
"upb/**/*.hpp",
"upb/**/*.inc",
],
exclude = [
"upb/**/conformance_upb.c",
Expand Down
1 change: 0 additions & 1 deletion upb/port/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ filegroup(
name = "source_files",
srcs = glob(
[
"**/*.c",
"**/*.h",
"**/*.inc",
],
Expand Down

0 comments on commit 00efe9f

Please sign in to comment.