invoke user defined join() #922

sirsnyder · 2019-02-01T01:33:26Z

@dktapps does that correspond to your issue #919?

dktapps · 2019-02-01T08:36:27Z

It appears to, yes. Haven't looked at this in close detail yet though. 👍

dktapps · 2019-02-01T08:37:39Z

src/object.c

+			}
+		}
+	} zend_catch {
+		pthreads_monitor_add(object->monitor, PTHREADS_MONITOR_ERROR);


isn't this case used for when the thread itself errored, as opposed to the parent thread crashing trying to stop it?

dktapps · 2019-02-01T08:38:48Z

src/object.c

+
+	ZVAL_UNDEF(&zresult);
+
+	pthreads_monitor_add(object->monitor, PTHREADS_MONITOR_RUNNING);


perhaps not what you intended?

dktapps · 2019-02-01T08:39:29Z

src/object.c

+		zval_ptr_dtor(&zresult);
+	}
+
+	pthreads_monitor_remove(object->monitor, PTHREADS_MONITOR_RUNNING);


Is this necessary? I was under the impression that this would already have happened by this point.

sorry, had copied the whole stuff from another function to see if it's working. now it's clean.

invoke user defined join()

d6a5e80

dktapps reviewed Feb 1, 2019

View reviewed changes

removed monitor state

69b5c21

Provide feedback


		ZVAL_UNDEF(&zresult);

		pthreads_monitor_add(object->monitor, PTHREADS_MONITOR_RUNNING);