Fix pathlib resolve (home-assistant#8311)

* Fix pathlib resolve * fix test
kressir · Jul 3, 2017 · ee7d471 · ee7d471
1 parent 3a6434f
commit ee7d471
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/homeassistant/core.py b/homeassistant/core.py
@@ -1079,7 +1079,7 @@ def is_allowed_path(self, path: str) -> bool:
         """Check if the path is valid for access from outside."""
         parent = pathlib.Path(path).parent
         try:
-            parent.resolve()  # pylint: disable=no-member
+            parent = parent.resolve()  # pylint: disable=no-member
         except (FileNotFoundError, RuntimeError, PermissionError):
             return False
 

diff --git a/tests/test_core.py b/tests/test_core.py
@@ -821,13 +821,13 @@ def test_is_allowed_path(self):
             for path in valid:
                 assert self.config.is_allowed_path(path)
 
-            self.config.whitelist_external_dirs = set(('/home',))
+            self.config.whitelist_external_dirs = set(('/home', '/var'))
 
             unvalid = [
                 "/hass/config/secure",
                 "/etc/passwd",
                 "/root/secure_file",
-                "/hass/config/test/../../../etc/passwd",
+                "/var/../etc/passwd",
                 test_file,
             ]
             for path in unvalid: