forked from rerun-io/rerun
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix python docstrings for dataframe APIs (rerun-io#7761)
### What - Resolves: rerun-io#7760 - Confirms that every item in `rerun_bindings.pyi` has a docstring - Validates that the docstrings from the .pyi actually match the `__doc__` strings provided by pyo3 - Updates griffe / mkdocstrings to get them to do the right thing TODO: - [x] Fix all the new issues this uncovers - [x] Clean up some of the docstrings where necessary to include Param defs, etc. - [x] Either get griffe to handle the missing .so or move doc tests to an environment with the built wheel If anybody wants to tackle cleaning some of this up: - Write docstrings on things in the `.pyi` file - Add matching docstrings to the corresponding rust functions - Run `pixi run py-build` and then `pixi run py-check-signatures` to verify everything looks good ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7761?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7761?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7761) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information
Showing
11 changed files
with
925 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,3 +61,7 @@ code { | |
.md-typeset a { | ||
--md-typeset-a-color: #526cfe; | ||
} | ||
|
||
.md-typeset h5 { | ||
text-transform: revert; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
griffe==0.39.0 | ||
mkdocs==1.5.3 | ||
griffe==1.4.1 | ||
mkdocs==1.6.1 | ||
mkdocs-gen-files==0.5.0 | ||
mkdocs-literate-nav==0.6.1 | ||
mkdocs-material==9.4.7 | ||
mkdocs-material-extensions==1.3 | ||
git+https://github.com/rerun-io/[email protected] # forked mkdocs-redirects with https://github.com/rerun-io/mkdocs-redirects/commit/d367a0847928438b66f73508e49852be1190409b | ||
mkdocstrings==0.23.0 | ||
mkdocstrings-python==1.7.3 | ||
mkdocstrings==0.26.2 | ||
mkdocstrings-python==1.12.1 | ||
mike==1.1.2 | ||
sphobjinv==2.3.1 | ||
typing_extensions==4.8.0 # uncaptured dep for mkdocstrings (https://github.com/mkdocstrings/mkdocstrings/issues/548) |
Oops, something went wrong.