feat(prover-sever): enhance error checking #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lightscale-luke
commented
Aug 22, 2023
•
lightscale-luke
commented
- update constants related to generate proof. (e.g., MAX_TXS, MAX_CALLDATA, etc)
- check if tx count from trace is smaller than MAX_TXS before starting proof creation.
- check if chain id in trace equals to prover's chain id.
- if requested with an incorrect prove type, prover returns error before initiating a trace object.
- detailed an error message in response.
lightscale-luke
force-pushed
the
feat/mainnet-config
branch
from
7a35e31 to
0b06ba1
Compare
fakedev9999
reviewed
Aug 22, 2023
fakedev9999
reviewed
Aug 22, 2023
dongchangYoo
force-pushed
the
feat/mainnet-config
branch
from
0b06ba1 to
95b5729
Compare
dongchangYoo
changed the title
dongchangYoo
force-pushed
the
feat/mainnet-config
branch
from
95b5729 to
4a934d1
Compare
|
@dongchangYoo For the commit message "feat(prover-server): increase request size to 32Mib" can you fix it to Mb? |
|
Please change commit title |
|
Could you add the reason why you increase request size to 32 Mib in commit body? |
dongchangYoo
force-pushed
the
feat/mainnet-config
branch
from
4a934d1 to
7fcecd3
Compare
lightscale-luke
force-pushed
the
feat/mainnet-config
branch
from
7fcecd3 to
8c38443
Compare
dongchangYoo
force-pushed
the
feat/mainnet-config
branch
from
8c38443 to
bd9da85
Compare
|
1 MiB stands for 1,000,000 bytes. However, it would be more accurate to express it as MiB instead of Mib. |
- bump default degree to 21 - increase values for MAX_TXS, MAX_CALLDATA and etc
- check if chain id in trace equals to prover's chain id. - check if num of txs in trace is less than MAX_TXS. - if requested with an incorrect prove type, prover returns error before initiating a trace object. - detailed an error message in response.
adjust the request size to process the JSON trace of a block containing 100 ERC-20 transfer transactions.
dongchangYoo
force-pushed
the
feat/mainnet-config
branch
from
bd9da85 to
d750cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.