Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify yumi_hw launchfiles #15

Open
YoshuaNava opened this issue Jan 21, 2018 · 1 comment
Open

Simplify yumi_hw launchfiles #15

YoshuaNava opened this issue Jan 21, 2018 · 1 comment
Assignees

Comments

@YoshuaNava
Copy link
Collaborator

YoshuaNava commented Jan 21, 2018

The current launchfiles are too many (4 for launching YuMi on gazebo, 4 for working on a physical one), only a couple lines of code change between them, and they don't provide any information as to which control interface will be used (EGM or RWS).

As a first step, we could divide the launchfiles in:

  • yumi_egm_vel_control
  • yumi_rws_pos_control
  • yumi_gazebo_vel_control
  • yumi_gazebo_pos_control

And have groups in the launchfiles to select which controllers we will use, by means of a "use_traj_controllers" parameter, as recommended by @diogoalmeida.

The changes related to this enhancement would be introduced at a slow pace, keeping the current launchfiles until the others are well tested and documented in the wiki.

@YoshuaNava YoshuaNava self-assigned this Jan 21, 2018
@diogoalmeida
Copy link
Member

Is this related to the fact that you could select which control mode you want through a launch file argument, instead of having several launch files where only a couple lines change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants