KTOR-7363 Fix ProtocolException when Websockets is used with Auth #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marychatte
force-pushed
the
marychatte/KTOR-7363-Websockets-and-Auth-ProtocolException
branch
from
a072139
to
5deeb5f
Compare
marychatte
force-pushed
the
marychatte/KTOR-7363-Websockets-and-Auth-ProtocolException
branch
from
5deeb5f
to
5078569
Compare
marychatte
force-pushed
the
marychatte/KTOR-7363-Websockets-and-Auth-ProtocolException
branch
from
5078569
to
377bbe4
Compare
bjhham
approved these changes
Sep 26, 2024
Comment on lines
+371
to
+377
| test { client -> | ||
| client.webSocket("$TEST_WEBSOCKET_SERVER/auth/websocket") { | ||
| val frame = incoming.receive() as Frame.Text | ||
| assertEquals("Hello from server", frame.readText()) | ||
| } | ||
| client.close() | ||
| } |
There was a problem hiding this comment.
Would be nice to include also test cases for a) valid initial token, and b) fully invalid token.
| @@ -350,4 +352,28 @@ class WebSocketTest : ClientLoader() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun testWithAuthPlugin() = clientTests( | |||
There was a problem hiding this comment.
Maybe a more specific name here, like "testAuthenticationWithRefreshTokens".
marychatte
deleted the
marychatte/KTOR-7363-Websockets-and-Auth-ProtocolException
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Websockets
Motivation
KTOR-7363