Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toleration in csi-kubevirt addon #3545

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mohamed-rafraf
Copy link
Member

@mohamed-rafraf mohamed-rafraf commented Jan 29, 2025

What this PR does / why we need it:
This PR will fix the unscheduled csi-kubevirt deployment
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix incorrect tolerations in the Kubevirt CSI addon

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). labels Jan 29, 2025
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2025
@mohamed-rafraf mohamed-rafraf marked this pull request as ready for review January 29, 2025 16:21
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f316889d92c040a7752ee46971802b959e4df3b8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@moadqassem moadqassem removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jan 30, 2025
@kubermatic-bot kubermatic-bot merged commit 8d01d28 into kubermatic:main Jan 30, 2025
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.10 milestone Jan 30, 2025
xmudrii pushed a commit that referenced this pull request Jan 30, 2025
@xmudrii
Copy link
Member

xmudrii commented Jan 30, 2025

/release-note-edit

Fix incorrect tolerations in the Kubevirt CSI addon

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 30, 2025
kubermatic-bot pushed a commit that referenced this pull request Jan 30, 2025
…branch (#3547)

* feat: add flag to skip TLS verification (#3522)

* feat: add flag to skip TLS verification

Signed-off-by: Stephan <[email protected]>

* Update addons/backups-restic/backups-restic.yaml

Co-authored-by: Artiom Diomin <[email protected]>
Signed-off-by: Stephan <[email protected]>

---------

Signed-off-by: Stephan <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>

* fix cloud config defaulting before terraform config apply (#3534)

* Make sure no slash at the end of vcenterPrefix (#3537)

Signed-off-by: Artiom Diomin <[email protected]>

* Fix kubevirt csi addon template (#3529)

* fix kubevirt csi addon template

* update internal images in template

* update internal images in template

* fix labels

* update addons

* update addons sa

* fix toleration (#3545)

* update Machine controller image (#3546)

* update Machine controller image

Signed-off-by: Mohamed Rafraf <[email protected]>

* update go.mod

---------

Signed-off-by: Mohamed Rafraf <[email protected]>

* labeling control-plane before (#3544)

---------

Signed-off-by: Stephan <[email protected]>
Signed-off-by: Artiom Diomin <[email protected]>
Signed-off-by: Mohamed Rafraf <[email protected]>
Co-authored-by: Stephan <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>
Co-authored-by: Mohamed Rafraf <[email protected]>
Co-authored-by: Artiom Diomin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants