Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Adds gofmt verification #485

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Adds gofmt verification #485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85f7c58
Adds gofmt verification
gitvinit Apr 11, 2023
dee4f48
Updates as per reviewer comments
gitvinit Apr 13, 2023
08a3d75
Updates as per reviewers comments
gitvinit Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updates as per reviewer comments
  • Loading branch information
@gitvinit
gitvinit committed Apr 13, 2023
commit dee4f488b1317a0e1eb2be39411bcaf0b1e7618a
3 changes: 2 additions & 1 deletion hack/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ pushing directly to a local registry and configuring kind to use this reg, so do
isnt required.
- Or a `tilt` recipe which hot reloads all kpng on code changes.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the future, these kind of linters are better integrated in the IDE, we can update the readme on a next moment with the instructions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sounds good

## Code formating
**We should run `hack/verify-gofmt.sh` before submitting a PR it checks whether the source code needs to be formatted or not and if anything fails run `hack/update-gofmt.sh` to actually format sources**.



Expand Down
2 changes: 1 addition & 1 deletion hack/update-gofmt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

# Copyright 2014 The Kubernetes Authors.
# Copyright 2023 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion hack/verify-gofmt.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

# Copyright 2021 The Kubernetes Authors.
# Copyright 2023 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down