-
Notifications
You must be signed in to change notification settings - Fork 91
Downgrade kpng alpine image to align nftables with nodes OS. #525
Downgrade kpng alpine image to align nftables with nodes OS. #525
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jayunit100, mneverov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok so this was the reason why it stopped working recently in the hack/local-up-kpng recipe i guesS? |
it might be related, but also the error you had is different... |
alpine is 3.18 now, I'm not sure we should downgrade for a specific node version. nftables is an in-kernel VM and nft compiles the given rules for this VM, hence it works in the kernel, even if the "decompilation" with an older version of nft is not guaranteed to work 100%. Downgrading nft means to going back in time, so less bugs fixed. To get the expected result from commands like |
@mcluseau yes, you're right. It explains why tests ran successfully on alpine 3.17. Sorry for the noise, ptal #527. Please let me know if I can bump golang build image to the latest alpine too and golang version to 1.21. |
@mneverov hey, no worries, thanks for contributing, there's no building without some noise :-) |
What kind of PR is this?
Hopefully a bugfix.
Why this PR is needed / What this PR do?
This PR aligns
nftables
version in kpng image and os node image.Currently, when e2e tests run locally nft rules set up incorrectly due to the versions mismatch that results in
[invalid type]
in chains.To reproduce
kpng
without running tests via./hack/test_e2e.sh -i ipv4 -b nft -d
nftables
and check forinvalid type
:kpng
has nothing to do with that. One can reproduce it by ssh-ing to a kpng pod and applying nft rules:On the node the new
test
table will look like:There is no
invalid type
message when the same steps are executed fromalpine:3.16
image.NOTE: I checked GH e2e action and it uses the same images (alpine 3.17 and ubuntu 22.04). When tests run locally I see invalid types during tests execution, but 335 tests run successfully so I suspect the chains with invalid types are not hit 🤷.
Probably related to the issue.
Which issue(s) this PR fixes?
Fixes #
Additional information about this PR