Merge pull request #225 from Fish-pro/fix-svc-status

fix: the service status of the loadbalancer type is incorrectly calculated
kubernetes-sigs · Jul 23, 2022 · 8ce143e · 8ce143e
2 parents c8e2959 + 21dfd2a
commit 8ce143e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/controllers/status.go b/controllers/status.go
@@ -194,7 +194,7 @@ func serviceStatus(u *unstructured.Unstructured) (string, error) {
  stype := service.Spec.Type
 
  if stype == corev1.ServiceTypeClusterIP || stype == corev1.ServiceTypeNodePort || stype == corev1.ServiceTypeExternalName ||
- stype == corev1.ServiceTypeLoadBalancer && isEmpty(service.Spec.ClusterIP) &&
+ stype == corev1.ServiceTypeLoadBalancer && !isEmpty(service.Spec.ClusterIP) &&
  len(service.Status.LoadBalancer.Ingress) > 0 && !hasEmptyIngressIP(service.Status.LoadBalancer.Ingress) {
  return StatusReady, nil
  }