Skip to content
This repository has been archived by the owner on Jul 7, 2023. It is now read-only.

Fix metric units and cleanup trigger #25

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix metric units and cleanup trigger #25

merged 1 commit into from
Jan 30, 2020

Conversation

floreks
Copy link
Contributor

@floreks floreks commented Jan 30, 2020

Fixes #24

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@floreks floreks added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@floreks floreks added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1e80bc3 into master Jan 30, 2020
@floreks floreks deleted the fix/metrics branch January 30, 2020 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store metricses in milli, but does not seem to be retrieved in milli
2 participants