Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update groups.yaml for sig scalability #7852

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Update groups.yaml for sig scalability #7852

merged 1 commit into from
Mar 7, 2025

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Mar 6, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Mar 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2025
shyamjvs
shyamjvs reviewed Mar 7, 2025
View reviewed changes
groups/sig-scalability/groups.yaml
- [email protected]
- [email protected]
- [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everywhere else you used corp email. Use the same here for consistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My GH handle is used in other PRs in kubernetes/community#8370 (comment)
I guess you may confuse my GH handle with my corp email. There's one letter difference.
I think I'm using my gmail in k8s community consistently. And both my gmail and corp email have been associated with my GH account. I don't think there will be any issue.

@shyamjvs
Copy link
Member

shyamjvs commented Mar 7, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit f9021a6 into kubernetes:main Mar 7, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 7, 2025
@mengqiy mengqiy deleted the patch-2 branch March 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjvs shyamjvs shyamjvs left review comments

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@shyamjvs shyamjvs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
3 participants
@mengqiy @shyamjvs @k8s-ci-robot