Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft OMS (Operations Management Suite) monitoring DaemonSet example #39538

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

OguzPastirmaci
Copy link

Adds example to deploy Microsoft OMS monitoring agents using Daemon Sets.

@k8s-ci-robot
Copy link
Contributor

Hi @OguzPastirmaci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jan 6, 2017
@brendandburns brendandburns added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jan 10, 2017
@brendandburns
Copy link
Contributor

@k8s-bot ok to test.

@brendandburns
Copy link
Contributor

Thanks for this PR. While it's great to have this in the examples, it would be even better to have it in the main site:

https://github.com/kubernetes/kubernetes.github.io

Feel free to do a PR there too and tag me into it.

Thanks!
--brendan

@OguzPastirmaci
Copy link
Author

Will do that one as well, thanks!

@brendandburns
Copy link
Contributor

@k8s-bot test this please

@k8s-github-robot
Copy link

k8s-github-robot commented Jan 24, 2017

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2017
@zmerlynn
Copy link
Member

/approve

@brendandburns: The parser is still strict, /approve has to be on the first line. (But the other order of your comment works.)

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3199898 into kubernetes:master Jan 26, 2017
@edevil
Copy link
Contributor

edevil commented Mar 24, 2017

I've noticed this daemonset example, but is it possible for the oms agent to augment the logging with kubernetes specific information such as pod name, namespace, tags, etc?

A bit like https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants