Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixups to 2025-02-14 ccm chicken and egg blog #49756

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Feb 14, 2025

Description

  • add a directory for the markdown and images
  • add a static svg image for the mermaid diagram
  • cleanup code blocks in erroneous places
  • switch svg references to use figure shortcode

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Feb 14, 2025

these are cleanups that came up in review on #49612

cc @sftim

Copy link

netlify bot commented Feb 14, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 575c56f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b0ac5638c1be00081274c7
😎 Deploy Preview https://deploy-preview-49756--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* add a directory for the markdown and images
* add a static svg image for the mermaid diagram
* cleanup code blocks in erroneous places
* switch svg references to use `figure` shortcode
@elmiko elmiko force-pushed the ccm-chick-egg-fixups branch from f0e175f to b95b184 Compare February 14, 2025 19:42
@elmiko
Copy link
Contributor Author

elmiko commented Feb 14, 2025

not quite sure why, but the svg file didn't render properly.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
for preview

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1e16eabab3be80a0682128c0f0007364dbe80b53

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2025
@sftim
Copy link
Contributor

sftim commented Feb 16, 2025

/hold cancel

We might need to fix the diagram more or make it zoomable, but this is an improvement.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit c795ec3 into kubernetes:main Feb 16, 2025
6 checks passed
@elmiko
Copy link
Contributor Author

elmiko commented Feb 17, 2025

thanks!

@elmiko elmiko deleted the ccm-chick-egg-fixups branch February 17, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants