Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image pulling logic to support different pull commands, fix crictl pull failure #2485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LazyBusyYang
Copy link

@LazyBusyYang LazyBusyYang commented Jan 8, 2025

  • Updated the image pulling mechanism to conditionally format the pull command based on the command type (e.g., crictl).
  • Improved code readability by reducing redundancy in command construction.

This change enhances flexibility in handling image pulls across different environments.

What type of PR is this?

bug

What this PR does / why we need it:

crictl pull has never supported an argument named platform

Which issue(s) this PR fixes:

Fixes #TODO

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


- Updated the image pulling mechanism to conditionally format the pull command based on the command type (e.g., crictl).
- Improved code readability by reducing redundancy in command construction.

This change enhances flexibility in handling image pulls across different environments.
Copy link

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LazyBusyYang
Once this PR has been reviewed and has the lgtm label, please assign pixiake for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Welcome @LazyBusyYang! It looks like this is your first PR to kubesphere/kubekey 🎉

@kubesphere-prow kubesphere-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

@pixiake
Copy link
Collaborator

pixiake commented Jan 14, 2025

@LazyBusyYang Thanks for this contributions. Please add sig-off for you commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container image pull arguments "--platform" not exits.
2 participants