Skip to content

Commit

Permalink
Merge pull request #396 from SOF3/jaeger-1.65.0
Browse files Browse the repository at this point in the history
fix(frontend): update to jaeger v1.65
  • Loading branch information
SOF3 authored Jan 14, 2025
2 parents 8868298 + 797f4aa commit f00842a
Show file tree
Hide file tree
Showing 16 changed files with 342 additions and 274 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.3-alpine AS build
FROM golang:1.23.4-alpine AS build

ARG GOPROXY
ARG GOPRIVATE
Expand Down
16 changes: 10 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ run: output/kelemetry $(DUMP_ROTATE_DEP)
--jaeger-backend=jaeger-storage \
--jaeger-trace-cache=$(ETCD_OR_LOCAL) \
--jaeger-trace-cache-etcd-endpoints=127.0.0.1:2379 \
--jaeger-storage.span-storage.type=grpc-plugin \
--jaeger-storage.span-storage.type=grpc \
--jaeger-storage.grpc-storage.server=127.0.0.1:17272 \
$(ENABLE_ARGS) \
$(REST_ARGS)
Expand Down Expand Up @@ -165,21 +165,25 @@ kwok-apiserver-host:
# Restart apiserver to reload config changes
docker restart kwok-tracetest-kube-apiserver

COMPOSE_COMMAND ?= up --build -d --remove-orphans
CHOWN_BADGER ?= yes
ifeq ($(CHOWN_BADGER), yes)
PROFILE_PREFIX := --profile chown-badger-volume
endif

COMPOSE_COMMAND ?= $(PROFILE_PREFIX) up --build -d --remove-orphans

stack:
docker compose -f dev.docker-compose.yaml up --no-recreate --no-start # create network only
docker compose \
-f dev.docker-compose.yaml \
-f <(jq -n \
--arg GATEWAY_ADDR $$(docker network inspect kelemetry_default -f '{{(index .IPAM.Config 0).Gateway}}') \
'.version = "2.2" | .services["jaeger-query"].environment.GRPC_STORAGE_SERVER = $$GATEWAY_ADDR + ":17271"' \
'.services["jaeger-query"].environment.GRPC_STORAGE_SERVER = $$GATEWAY_ADDR + ":17271"' \
) \
$(COMPOSE_COMMAND)

define QUICKSTART_JQ_PATCH
if $$KELEMETRY_IMAGE == "" then .services.kelemetry.build |= (.dockerfile = "./Dockerfile" | .context = ".") else . end |
if $$KELEMETRY_IMAGE != "" then .services.kelemetry.image = $$KELEMETRY_IMAGE else . end
if $$KELEMETRY_IMAGE != "" then .services.kelemetry |= (.image = $$KELEMETRY_IMAGE | del(.build)) else . end
endef

SED_I_FLAG =
Expand Down Expand Up @@ -227,5 +231,5 @@ local-docker-build:

e2e: local-docker-build
make quickstart COMPOSE_COMMAND='down --remove-orphans --volumes' KELEMETRY_IMAGE=kelemetry:local
make quickstart COMPOSE_COMMAND='up --build -d --remove-orphans' KELEMETRY_IMAGE=kelemetry:local
make quickstart COMPOSE_COMMAND='--profile chown-badger-volume up --build -d --remove-orphans' KELEMETRY_IMAGE=kelemetry:local
bash e2e/run-all.sh
2 changes: 1 addition & 1 deletion charts/kelemetry/templates/_helpers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ jaeger-trace-cache-etcd-prefix: {{ .Values.frontend.traceCache.etcd.prefix | toJ
{{- end }}
{{- end }}
{{- define "kelemetry.storage-options-stateful-grpc" }}
span-storage.type: grpc-plugin
span-storage.type: grpc
grpc-storage.server: {{.Release.Name}}-storage.{{.Release.Namespace}}.svc:17271
{{- end }}
{{- define "kelemetry.storage-options-stateless-raw" }}
Expand Down
2 changes: 1 addition & 1 deletion charts/kelemetry/templates/frontend.deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
- name: GRPC_STORAGE_SERVER
value: localhost:17271
- name: SPAN_STORAGE_TYPE
value: grpc-plugin
value: grpc
- name: storage-plugin
{{ include "kelemetry.container-boilerplate" .Values.frontend.storagePlugin | nindent 10 }}
image: {{ printf "%s:%s" .Values.kelemetryImage.repository (.Values.kelemetryImage.tag | default .Chart.AppVersion) | toJson }}
Expand Down
6 changes: 3 additions & 3 deletions charts/kelemetry/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -410,13 +410,13 @@ jaegerImages:
pullSecrets: []
query:
repository: jaegertracing/jaeger-query
tag: "1.42"
tag: "1.65.0"
collector:
repository: jaegertracing/jaeger-collector
tag: "1.42"
tag: "1.65.0"
remoteStorage:
repository: jaegertracing/jaeger-remote-storage
tag: "1.42"
tag: "1.65.0"

# The shared etcd database.
# It is only deployed if at least one of diffCache/spanCache/traceCache uses etcd with externalEndpoint=false.
Expand Down
26 changes: 18 additions & 8 deletions dev.docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,27 @@ services:
memory: 1G
# Web frontend for trace view.
jaeger-query:
image: jaegertracing/jaeger-query:1.42
image: jaegertracing/jaeger-query:1.65.0
environment:
SPAN_STORAGE_TYPE: grpc-plugin
SPAN_STORAGE_TYPE: grpc
GRPC_STORAGE_SERVER: host.docker.internal:17271 # run on host directly
ports:
- 0.0.0.0:16686:16686
restart: always
# OTLP collector that writes to Badger
jaeger-collector:
image: jaegertracing/jaeger-collector:1.42
image: jaegertracing/jaeger-collector:1.65.0
environment:
COLLECTOR_OTLP_ENABLED: "true"
SPAN_STORAGE_TYPE: grpc-plugin
SPAN_STORAGE_TYPE: grpc
GRPC_STORAGE_SERVER: remote-badger:17271
ports:
- 0.0.0.0:4317:4317
restart: always
# Backend badger storage
# Feel free to override environment.SPAN_STORAGE_TYPE to other storages given the proper configuration.
remote-badger:
image: jaegertracing/jaeger-remote-storage:1.42
image: jaegertracing/jaeger-remote-storage:1.65.0
environment:
SPAN_STORAGE_TYPE: badger
BADGER_EPHEMERAL: "false"
Expand All @@ -62,17 +62,27 @@ services:
resources:
limits:
memory: 1G

# Web frontend for raw trace database view.
jaeger-query-raw:
image: jaegertracing/jaeger-query:1.42
image: jaegertracing/jaeger-query:1.65.0
environment:
SPAN_STORAGE_TYPE: grpc-plugin
SPAN_STORAGE_TYPE: grpc
GRPC_STORAGE_SERVER: remote-badger:17271
ports:
- 0.0.0.0:26686:16686
restart: always

# Hack service to chown badger volume for 10001 (user of jaeger-remote-storage)
chown-badger-volume:
profiles:
- chown-badger-volume
image: jaegertracing/jaeger-remote-storage:1.65.0
user: root
entrypoint: /bin/ash
command: ["-c", "chown 10001:10001 /mnt/badger && sleep infinity"]
volumes:
- badger:/mnt/badger

volumes:
etcd: {}
badger: {}
122 changes: 69 additions & 53 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/kubewharf/kelemetry

go 1.22.0
go 1.23.0

toolchain go1.22.3
toolchain go1.23.4

require (
github.com/coocood/freecache v1.2.4
Expand All @@ -11,7 +11,7 @@ require (
github.com/gin-gonic/gin v1.10.0
github.com/go-logr/logr v1.4.2
github.com/itchyny/gojq v0.12.17
github.com/jaegertracing/jaeger v1.57.0
github.com/jaegertracing/jaeger v1.65.0
github.com/pelletier/go-toml/v2 v2.2.3
github.com/prometheus/client_golang v1.20.5
github.com/segmentio/golines v0.12.2
Expand All @@ -21,86 +21,80 @@ require (
github.com/stretchr/testify v1.10.0
go.etcd.io/etcd/client/v3 v3.5.17
go.opentelemetry.io/otel v1.33.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.32.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.28.0
go.opentelemetry.io/otel/sdk v1.32.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.33.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.33.0
go.opentelemetry.io/otel/sdk v1.33.0
go.opentelemetry.io/otel/trace v1.33.0
go.uber.org/zap v1.27.0
golang.org/x/tools v0.28.0
google.golang.org/grpc v1.65.0
k8s.io/api v0.31.1
k8s.io/apimachinery v0.31.1
k8s.io/apiserver v0.31.0
k8s.io/client-go v0.31.1
google.golang.org/grpc v1.69.2
k8s.io/api v0.32.0
k8s.io/apimachinery v0.32.0
k8s.io/apiserver v0.32.0
k8s.io/client-go v0.32.0
k8s.io/klog/v2 v2.130.1
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738
mvdan.cc/gofumpt v0.7.0
)

require (
github.com/Shopify/sarama v1.38.1 // indirect
github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 // indirect
github.com/alecthomas/units v0.0.0-20231202071711-9a357b53e9c9 // indirect
github.com/apache/thrift v0.20.0 // indirect
github.com/apache/thrift v0.21.0 // indirect
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/bytedance/sonic v1.11.6 // indirect
github.com/bytedance/sonic/loader v0.1.1 // indirect
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
github.com/cespare/xxhash v1.1.0 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/cloudwego/base64x v0.1.4 // indirect
github.com/cloudwego/iasm v0.2.0 // indirect
github.com/coreos/go-semver v0.3.1 // indirect
github.com/coreos/go-systemd/v22 v22.5.0 // indirect
github.com/dave/dst v0.27.3 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/dgraph-io/badger/v3 v3.2103.5 // indirect
github.com/dgraph-io/ristretto v0.1.1 // indirect
github.com/dgraph-io/badger/v4 v4.5.0 // indirect
github.com/dgraph-io/ristretto/v2 v2.0.0 // indirect
github.com/dustin/go-humanize v1.0.1 // indirect
github.com/eapache/go-resiliency v1.6.0 // indirect
github.com/eapache/go-resiliency v1.7.0 // indirect
github.com/eapache/go-xerial-snappy v0.0.0-20230731223053-c322873962e3 // indirect
github.com/eapache/queue v1.1.0 // indirect
github.com/elastic/elastic-transport-go/v8 v8.5.0 // indirect
github.com/elastic/go-elasticsearch/v8 v8.13.1 // indirect
github.com/elastic/elastic-transport-go/v8 v8.6.0 // indirect
github.com/elastic/go-elasticsearch/v8 v8.17.0 // indirect
github.com/emicklei/go-restful/v3 v3.11.0 // indirect
github.com/fatih/color v1.15.0 // indirect
github.com/fatih/structtag v1.2.0 // indirect
github.com/fsnotify/fsnotify v1.7.0 // indirect
github.com/fsnotify/fsnotify v1.8.0 // indirect
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
github.com/gabriel-vasile/mimetype v1.4.3 // indirect
github.com/gin-contrib/sse v0.1.0 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-openapi/jsonpointer v0.20.0 // indirect
github.com/go-openapi/jsonpointer v0.21.0 // indirect
github.com/go-openapi/jsonreference v0.20.2 // indirect
github.com/go-openapi/swag v0.22.4 // indirect
github.com/go-openapi/swag v0.23.0 // indirect
github.com/go-playground/locales v0.14.1 // indirect
github.com/go-playground/universal-translator v0.18.1 // indirect
github.com/go-playground/validator/v10 v10.20.0 // indirect
github.com/goccy/go-json v0.10.2 // indirect
github.com/gocql/gocql v1.3.2 // indirect
github.com/goccy/go-json v0.10.4 // indirect
github.com/gocql/gocql v1.7.0 // indirect
github.com/gogo/googleapis v1.4.1 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/glog v1.2.1 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/golang/snappy v0.0.4 // indirect
github.com/google/flatbuffers v23.1.21+incompatible // indirect
github.com/google/flatbuffers v24.3.25+incompatible // indirect
github.com/google/gnostic-models v0.6.8 // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/google/gofuzz v1.2.0 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.24.0 // indirect
github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/hashicorp/go-hclog v1.6.3 // indirect
github.com/hashicorp/go-multierror v1.1.1 // indirect
github.com/hashicorp/go-plugin v1.6.0 // indirect
github.com/hashicorp/go-uuid v1.0.3 // indirect
github.com/hashicorp/go-version v1.7.0 // indirect
github.com/hashicorp/hcl v1.0.0 // indirect
github.com/hashicorp/yamux v0.1.1 // indirect
github.com/hexops/gotextdiff v1.0.3 // indirect
github.com/imdario/mergo v0.3.13 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/itchyny/timefmt-go v0.1.6 // indirect
github.com/jcmturner/aescts/v2 v2.0.0 // indirect
Expand All @@ -110,7 +104,7 @@ require (
github.com/jcmturner/rpc/v2 v2.0.3 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.17.9 // indirect
github.com/klauspost/compress v1.17.11 // indirect
github.com/klauspost/cpuid/v2 v2.2.7 // indirect
github.com/leodido/go-urn v1.4.0 // indirect
github.com/magiconair/properties v1.8.7 // indirect
Expand All @@ -119,19 +113,18 @@ require (
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/mattn/go-runewidth v0.0.15 // indirect
github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d // indirect
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
github.com/mitchellh/mapstructure v1.5.1-0.20231216201459-8508981c8b6c // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/mostynb/go-grpc-compression v1.2.3 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/nxadm/tail v1.4.11 // indirect
github.com/oklog/run v1.1.0 // indirect
github.com/olivere/elastic v6.2.37+incompatible // indirect
github.com/pierrec/lz4/v4 v4.1.21 // indirect
github.com/pierrec/lz4/v4 v4.1.22 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/prometheus/client_model v0.6.1 // indirect
github.com/prometheus/common v0.55.0 // indirect
github.com/prometheus/common v0.61.0 // indirect
github.com/prometheus/procfs v0.15.1 // indirect
github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475 // indirect
github.com/rivo/uniseg v0.4.7 // indirect
Expand All @@ -153,32 +146,55 @@ require (
go.etcd.io/etcd/client/pkg/v3 v3.5.17 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.53.0 // indirect
go.opentelemetry.io/collector/client v1.22.0 // indirect
go.opentelemetry.io/collector/component v0.116.0 // indirect
go.opentelemetry.io/collector/component/componentstatus v0.116.0 // indirect
go.opentelemetry.io/collector/component/componenttest v0.116.0 // indirect
go.opentelemetry.io/collector/config/configauth v0.116.0 // indirect
go.opentelemetry.io/collector/config/configcompression v1.22.0 // indirect
go.opentelemetry.io/collector/config/configgrpc v0.116.0 // indirect
go.opentelemetry.io/collector/config/confignet v1.22.0 // indirect
go.opentelemetry.io/collector/config/configopaque v1.22.0 // indirect
go.opentelemetry.io/collector/config/configretry v1.22.0 // indirect
go.opentelemetry.io/collector/config/configtelemetry v0.116.0 // indirect
go.opentelemetry.io/collector/config/configtls v1.22.0 // indirect
go.opentelemetry.io/collector/config/internal v0.116.0 // indirect
go.opentelemetry.io/collector/consumer v1.22.0 // indirect
go.opentelemetry.io/collector/consumer/consumererror v0.116.0 // indirect
go.opentelemetry.io/collector/exporter v0.116.0 // indirect
go.opentelemetry.io/collector/extension v0.116.0 // indirect
go.opentelemetry.io/collector/extension/auth v0.116.0 // indirect
go.opentelemetry.io/collector/extension/experimental/storage v0.116.0 // indirect
go.opentelemetry.io/collector/featuregate v1.22.0 // indirect
go.opentelemetry.io/collector/pdata v1.22.0 // indirect
go.opentelemetry.io/collector/pdata/pprofile v0.116.0 // indirect
go.opentelemetry.io/collector/pipeline v0.116.0 // indirect
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.58.0 // indirect
go.opentelemetry.io/otel/metric v1.33.0 // indirect
go.opentelemetry.io/proto/otlp v1.3.1 // indirect
go.opentelemetry.io/otel/sdk/metric v1.33.0 // indirect
go.opentelemetry.io/proto/otlp v1.4.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
golang.org/x/arch v0.8.0 // indirect
golang.org/x/crypto v0.31.0 // indirect
golang.org/x/exp v0.0.0-20240119083558-1b970713d09a // indirect
golang.org/x/crypto v0.32.0 // indirect
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect
golang.org/x/mod v0.22.0 // indirect
golang.org/x/net v0.32.0 // indirect
golang.org/x/oauth2 v0.21.0 // indirect
golang.org/x/net v0.34.0 // indirect
golang.org/x/oauth2 v0.24.0 // indirect
golang.org/x/sync v0.10.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/term v0.27.0 // indirect
golang.org/x/sys v0.29.0 // indirect
golang.org/x/term v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
golang.org/x/time v0.5.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20240701130421-f6361c86f094 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240701130421-f6361c86f094 // indirect
google.golang.org/protobuf v1.35.1 // indirect
golang.org/x/time v0.7.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20241209162323-e6fa225c2576 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241216192217-9240e9c98484 // indirect
google.golang.org/protobuf v1.36.1 // indirect
gopkg.in/alecthomas/kingpin.v2 v2.2.6 // indirect
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/ini.v1 v1.67.0 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f // indirect
sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
sigs.k8s.io/yaml v1.4.0 // indirect
)
Loading

0 comments on commit f00842a

Please sign in to comment.