analytics: Cleanup confusingly type-variable all_records.

kwikadi · Feb 4, 2016 · 2436ad1 · 2436ad1
1 parent 23705f4
commit 2436ad1
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/analytics/views.py b/analytics/views.py
@@ -818,7 +818,6 @@ def by_used_time(row):
 @zulip_internal
 def get_realm_activity(request, realm):
     data = []
-    all_records = {}
     all_user_records = {}
 
     try:
@@ -829,8 +828,7 @@ def get_realm_activity(request, realm):
     admin_emails = {admin.email for admin in admins}
 
     for is_bot, page_title in [(False,  'Humans'), (True, 'Bots')]:
-        all_records = get_user_activity_records_for_realm(realm, is_bot)
-        all_records = list(all_records)
+        all_records = list(get_user_activity_records_for_realm(realm, is_bot))
 
         user_records, content = realm_user_summary_table(all_records, admin_emails)
         all_user_records.update(user_records)