demonstrate issue ThreeMammals#169

kyle0830 · Dec 4, 2017 · 189471c · 189471c
1 parent 9232766
commit 189471c
Showing 1 changed file with 39 additions and 0 deletions.
diff --git a/test/Ocelot.UnitTests/DependencyInjection/OcelotBuilderTests.cs b/test/Ocelot.UnitTests/DependencyInjection/OcelotBuilderTests.cs
@@ -5,12 +5,15 @@
 using System.Text;
 using CacheManager.Core;
 using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Hosting.Internal;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Ocelot.Cache;
 using Ocelot.Configuration;
 using Ocelot.Configuration.File;
+using Ocelot.Configuration.Setter;
 using Ocelot.DependencyInjection;
+using Ocelot.Logging;
 using Shouldly;
 using TestStack.BDDfy;
 using Xunit;
@@ -20,6 +23,7 @@ namespace Ocelot.UnitTests.DependencyInjection
     public class OcelotBuilderTests
     {
         private IServiceCollection _services;
+        private IServiceProvider _serviceProvider;
         private IConfigurationRoot _configRoot;
         private IOcelotBuilder _ocelotBuilder;
         private int _maxRetries;
@@ -30,6 +34,7 @@ public OcelotBuilderTests()
                 _configRoot = new ConfigurationRoot(new List<IConfigurationProvider>());
                 _services = new ServiceCollection();
                 _services.AddSingleton(builder);
+                _services.AddSingleton<IHostingEnvironment, HostingEnvironment>();
                 _maxRetries = 100;
         }
         private Exception _ex;
@@ -70,6 +75,16 @@ public void should_set_up_consul()
                 .BDDfy();
         }
 
+        [Fact]
+        public void should_use_logger_factory()
+        {
+            this.Given(x => WhenISetUpOcelotServices())
+                .When(x => WhenIValidateScopes())
+                .When(x => WhenIAccessLoggerFactory())
+                .Then(x => ThenAnExceptionIsntThrown())
+                .BDDfy();
+        }
+
         private void OnlyOneVersionOfEachCacheIsRegistered()
         {
             var outputCache = _services.Single(x => x.ServiceType == typeof(IOcelotCache<CachedResponse>));
@@ -127,6 +142,30 @@ private void WhenISetUpCacheManager()
             }
         }
 
+        private void WhenIAccessLoggerFactory()
+        {
+            try
+            {
+                var logger = _serviceProvider.GetService<IFileConfigurationSetter>();
+            }
+            catch (Exception e)
+            {
+                _ex = e;
+            }
+        }
+
+        private void WhenIValidateScopes()
+        {
+            try
+            {
+                _serviceProvider = _services.BuildServiceProvider(new ServiceProviderOptions { ValidateScopes = true });
+            }
+            catch (Exception e)
+            {
+                _ex = e;
+            }
+        }
+
         private void ThenAnExceptionIsntThrown()
         {
             _ex.ShouldBeNull();