Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple movies db scores #114

Closed
wants to merge 1 commit into from
Closed

Support multiple movies db scores #114

wants to merge 1 commit into from

Conversation

lightglitch
Copy link

It still needs some testing but feedback is welcome.

@desimaniac
Copy link
Collaborator

Thanks. Will check this out in a bit

@crypto-vault
Copy link

I hope this gets merged. Omdb lacks a lot on rotten ratings for new releases. Using IMDb would get some more results.

@crypto-vault
Copy link

You're using a float for imdb_rating, but when logging you're using an integer so you get something like: "Minimum Rotten Tomatoes score of 50%, IMDB score 5%, Metacritic score 50% requested." when using IMDB score 5.0 as an example. You need to replace logging from %d to %.1f

@lightglitch
Copy link
Author

@crypto-vault thx for the feedback

@lightglitch
Copy link
Author

@desimaniac can you merge this, thx

@hyperhydra98
Copy link

@l3uddz @desimaniac @horjulf @nemchik @zenjabba Would one you you be able to please help merge this? It would be a great addition to Traktarr as many OMDb results lack RT ratings.

@jacobtipp
Copy link

@l3uddz @desimaniac @horjulf @nemchik @zenjabba Would one you you be able to please help merge this? It would be a great addition to Traktarr as many OMDb results lack RT ratings.

I agree, I run traktarr on several docker containers and being able to use ratings from other providers would be a great addition

@lightglitch
Copy link
Author

I stopped using traktarr and created my own tool https://github.com/lightglitch/seekerr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants