Skip to content

Commit

Permalink
activity: Ignore presence responses when trying to reload.
Browse files Browse the repository at this point in the history
This avoids risk of logging blueslip errors for user IDs seen in the
presence response that we haven't heard about from the server_events
system because we're offline and in the process of reloading.

The issue only affected large realms; see
02bc630 and `git log
-Ssuspect_offline` for details.
  • Loading branch information
timabbott committed Feb 13, 2020
1 parent a91358e commit 3f76124
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions static/js/activity.js
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,10 @@ function send_presence_to_server(want_redraw) {
},
idempotent: true,
success: function (data) {
if (reload_state.is_in_progress()) {
blueslip.log("Ignoring presence response because reload in progress");
return;
}

// Update Zephyr mirror activity warning
if (data.zephyr_mirror_active === false) {
Expand Down

0 comments on commit 3f76124

Please sign in to comment.