Change elliptic curve new point function

[nicole-graus]

Change elliptic curve new point function

Description

This PR changes the function new for every elliptic curve in Lambdaworks. In the previous version, this function creates a new curve point but doesn't check if it satisfies the curve equation. In this PR the function checks if the point is valid returning a Result.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.76212% with 40 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (d78d18a) to head (1a3e82f).

Files with missing lines	Patch %	Lines
math/src/elliptic_curve/short_weierstrass/point.rs	84.04%	15 Missing ⚠️
...ptic_curve/short_weierstrass/curves/stark_curve.rs	0.00%	9 Missing ⚠️
.../src/elliptic_curve/edwards/curves/tiny_jub_jub.rs	0.00%	7 Missing ⚠️
...c/elliptic_curve/montgomery/curves/tiny_jub_jub.rs	0.00%	7 Missing ⚠️
math/src/elliptic_curve/montgomery/traits.rs	75.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   71.49%   71.67%   +0.17%     
==========================================
  Files         156      156              
  Lines       33969    34271     +302     
==========================================
+ Hits        24287    24564     +277     
- Misses       9682     9707      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[diegokingston]

This could be more efficient just by factoring out z^2. We can update that in future PR

[Oppen]

Overall it looks correct, however:

1. Did we check that the use of .unwrap_unchecked() actually provides any advantage over regular .unwrap()?
2. I would suggest, regardless of which kind of unwrap we use, that we do something like the following:

let val = Curve::new(...);
debug_assert!(val.is_some());
val.unwrap()

That way we can make sure the condition holds in debug builds, without introducing any checking overhead in release builds.