impr: Better UI and UX for the hex editor footer

landv · Mar 21, 2024 · ed2939c · ed2939c
1 parent d36bd25
commit ed2939c
Show file tree

Hide file tree

Showing 4 changed files with 136 additions and 162 deletions.
diff --git a/lib/libimhex/source/api/imhex_api.cpp b/lib/libimhex/source/api/imhex_api.cpp
@@ -75,7 +75,11 @@ namespace hex {
 
             static AutoReset<std::optional<ProviderRegion>> s_currentSelection;
             void setCurrentSelection(const std::optional<ProviderRegion> &region) {
-                *s_currentSelection = region;
+                if (region == Region::Invalid()) {
+                    clearSelection();
+                } else {
+                    *s_currentSelection = region;
+                }
             }
 
             static PerProvider<std::optional<Region>> s_hoveredRegion;

diff --git a/plugins/builtin/source/content/ui_items.cpp b/plugins/builtin/source/content/ui_items.cpp
@@ -308,6 +308,16 @@ namespace hex::plugin::builtin {
                 }
             }
         });
+
+        ContentRegistry::Interface::addFooterItem([] {
+            if (auto selection = ImHexApi::HexEditor::getSelection(); selection.has_value()) {
+                ImGuiExt::TextFormattedSelectable("0x{:02X} - 0x{:02X} ({} bytes)",
+                    selection->getStartAddress(),
+                    selection->getEndAddress(),
+                    selection->getSize()
+                );
+            }
+        });
     }
 
     static void drawProviderContextMenu(prv::Provider *provider) {

diff --git a/plugins/ui/romfs/lang/en_US.json b/plugins/ui/romfs/lang/en_US.json
@@ -85,6 +85,7 @@
         "hex.ui.common.yes": "Yes",
         "hex.ui.hex_editor.ascii_view": "Display ASCII column",
         "hex.ui.hex_editor.custom_encoding_view": "Display advanced decoding column",
+        "hex.ui.hex_editor.columns": "Columns",
         "hex.ui.hex_editor.human_readable_units_footer": "Convert sizes to human-readable units",
         "hex.ui.hex_editor.data_size": "Data Size",
         "hex.ui.hex_editor.gray_out_zero": "Grey out zeros",