Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Improve MIME type detection for remote URL uploads using python-magic #12693

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

yjc980121
Copy link
Contributor

Resolved issue where binary files (e.g., .docx) were misidentified as .bin due to defaulting to application/octet-stream. Added python-magic as a secondary fallback to accurately detect MIME types from file content for remote URL uploads.

Summary

Resolved issue where binary files (e.g., .docx) were misidentified as .bin due to defaulting to application/octet-stream. Added python-magic as a secondary fallback to accurately detect MIME types from file content for remote URL uploads.

Fixes #12551

Dependency Check

  • python-magic is implicitly available as a transitive dependency (via another package), so no additional changes to pyproject.toml or poetry.lock are required.

Checklist

[!IMPORTANT]

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 13, 2025
@laipz8200
Copy link
Member

Hi @yjc980121, thank you for your contribution! Please run dev/reformat to pass the CI check.

@laipz8200
Copy link
Member

Hi, some conflicts need to be resolved.

Copy link
Contributor

@y10ab1 y10ab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just waiting for this fix.

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 24, 2025
@crazywoola crazywoola merged commit aad7e4d into langgenius:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect File Format Returned for .docx Upload via Remote URL
4 participants