Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 500 error in Notion integration API #12934

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: 500 error in Notion integration API #12934

merged 1 commit into from
Jan 22, 2025

Conversation

nagaihiroki-git
Copy link

Summary

Fixed 500 error in Notion integration API caused by incorrect SQLAlchemy query result handling. The issue occurred when users tried to access Notion workspace list in the knowledge base section.

Changes made:

  • Replace session.execute() with session.scalars() in DataSourceNotionListApi
  • Fix SQLAlchemy query result handling for notion workspace listing
  • Ensure proper model instance access for source_info

No new dependencies required.

Fixes #12933

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@nagaihiroki-git
fix: fix 500 error in Notion integration API
915be3a 
- Replace session.execute() with session.scalars() in DataSourceNotionListApi
- Fix SQLAlchemy query result handling for notion workspace listing
- Ensure proper model instance access for source_info
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 22, 2025
@nagaihiroki-git nagaihiroki-git changed the title fix: fix 500 error in Notion integration API fix: 500 error in Notion integration API Jan 22, 2025
@crazywoola crazywoola requested a review from Yeuoly January 22, 2025 06:32
Yeuoly
Yeuoly approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@Yeuoly Yeuoly merged commit 15ee1e1 into langgenius:plugins/beta Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yeuoly Yeuoly Yeuoly approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nagaihiroki-git @Yeuoly