Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain previous page's search params #14176

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

obadakhalili
Copy link
Contributor

@obadakhalili obadakhalili commented Feb 21, 2025

Summary

When I'm on the /apps page and use the available options (tags, keywords search, etc.) to filter the listed apps, I find it annoying that after selecting an app and pressing the back button my filters disappear.

Closes #14190.

This change:

  • updates the navigation component to retain the search parameters of the parent page link
  • includes the "Created by Me" value as a search parameter as well

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Feb 21, 2025
@crazywoola
Copy link
Member

Thanks for the PR :)

Please open an issue or linking an existing issue in the description.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 23, 2025
@crazywoola crazywoola merged commit 5ac0ef6 into langgenius:main Feb 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retain previous page's search params when clicking the back button inside the studio
2 participants