fix: drop password existence check #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 91.57% 91.27% -0.30%
==========================================
Files 1 1
Lines 178 172 -6
Branches 24 23 -1
==========================================
- Hits 163 157 -6
Misses 10 10
Partials 5 5 ☔ View full report in Codecov by Sentry. |
languitar
force-pushed
the
revert/existence-check
branch
from
4fa0d82
to
afe7ae2
Compare
languitar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new feature for checking whether a password exists in the store before using it makes pass-git-helper incompatible with pass lookalikes.
Fixes #387, reverts #372
This reverts commit b50ca3b.