Adhere to review

lantisnt · Sep 25, 2022 · 93f3172 · 93f3172
1 parent e10b8c7
commit 93f3172
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/AceConfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua b/AceConfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua
@@ -153,7 +153,7 @@ local stringIsLiteral = {
  width = true,
  image = true,
  fontSize = true,
- item = true
+ tooltipHyperlink = true
 }
 
 --Is Never a function or method
@@ -509,15 +509,12 @@ local function OptionOnMouseOver(widget, event)
  local tooltip = AceConfigDialog.tooltip
 
 
- local item = GetOptionsMemberValue("item", opt, options, path, appName)
- if item then
- if type(item) == "number" then
- item = "item:" .. tostring(item)
- end
- if GetItemInfoInstant(item) then
+ local tooltipHyperlink = GetOptionsMemberValue("tooltipHyperlink", opt, options, path, appName)
+ if tooltipHyperlink then
+ if GetItemInfoInstant(tooltipHyperlink) then
  AceConfigDialog.GameTooltip = GameTooltip
  AceConfigDialog.GameTooltip:SetOwner(widget.frame, "ANCHOR_TOPRIGHT")
- AceConfigDialog.GameTooltip:SetHyperlink(item)
+ AceConfigDialog.GameTooltip:SetHyperlink(tooltipHyperlink)
  AceConfigDialog.GameTooltip:Show()
  return
  end

diff --git a/AceConfig-3.0/AceConfigRegistry-3.0/AceConfigRegistry-3.0.lua b/AceConfig-3.0/AceConfigRegistry-3.0/AceConfigRegistry-3.0.lua
@@ -83,7 +83,7 @@ local basekeys={
  dialogHidden=optmethodbool,
  dropdownHidden=optmethodbool,
  cmdHidden=optmethodbool,
- item=optstringnumberfunc,
+ tooltipHyperlink=optstringfunc,
  icon=optstringnumberfunc,
  iconCoords=optmethodtable,
  handler=opttable,