code linting

.eslintrc

@@ -8,6 +8,13 @@
 	"rules": {
 		"quotes": ["error", "double"],
 		"no-undef": "error",
+		"no-extra-semi": "error",
+		"semi": "error",
+		"no-template-curly-in-string": "error",
+		"no-caller": "error",
+		"yoda": "error",
+		"eqeqeq": "error",
+		"global-require": "off",
 		"brace-style": "error",
 		"eol-last": "error",
 		"indent": ["error", "tab", { "SwitchCase": 1 }],

bin/convert-argv.js

@@ -46,7 +46,7 @@ module.exports = function(yargs, argv, convertOptions) {
 				}
 			}
 			return path.extname(configPath);
-		}
+		};
 
 		var mapConfigArg = function mapConfigArg(configArg) {
 			var resolvedPath = path.resolve(configArg);
@@ -55,7 +55,7 @@ module.exports = function(yargs, argv, convertOptions) {
 				path: resolvedPath,
 				ext: extension
 			};
-		}
+		};
 
 		var configArgList = Array.isArray(argv.config) ? argv.config : [argv.config];
 		configFiles = configArgList.map(mapConfigArg);
@@ -90,7 +90,7 @@ module.exports = function(yargs, argv, convertOptions) {
 					}
 				}
 			}
-		}
+		};
 
 		var requireConfig = function requireConfig(configPath) {
 			var options = require(configPath);
@@ -102,7 +102,7 @@ module.exports = function(yargs, argv, convertOptions) {
 				options = options(argv.env, argv);
 			}
 			return options;
-		}
+		};
 
 		configFiles.forEach(function(file) {
 			registerCompiler(interpret.extensions[file.ext]);
@@ -511,7 +511,7 @@ module.exports = function(yargs, argv, convertOptions) {
 				} else {
 					options.entry[name] = entry;
 				}
-			}
+			};
 			argv._.forEach(function(content) {
 				var i = content.indexOf("=");
 				var j = content.indexOf("?");

buildin/module.js

@@ -21,4 +21,4 @@ module.exports = function(module) {
 		module.webpackPolyfill = 1;
 	}
 	return module;
-}
+};

examples/agressive-merging/webpack.config.js

@@ -17,4 +17,4 @@ module.exports = {
 			moveToParents: true
 		})
 	]
-}
+};

examples/chunkhash/webpack.config.js

@@ -20,4 +20,4 @@ module.exports = {
 		})
 		*/
 	]
-};
+};

examples/code-splitted-css-bundle/webpack.config.js

@@ -17,4 +17,4 @@ module.exports = {
 			filename: "style.css"
 		})
 	]
-};
+};

examples/coffee-script/webpack.config.js

@@ -7,4 +7,4 @@ module.exports = {
 	resolve: {
 		extensions: [".web.coffee", ".web.js", ".coffee", ".js"]
 	}
-}
+};

examples/css-bundle/webpack.config.js

@@ -17,4 +17,4 @@ module.exports = {
 			allChunks: true
 		})
 	]
-};
+};

examples/dll-user/webpack.config.js

@@ -4,11 +4,11 @@ module.exports = {
 	plugins: [
 		new webpack.DllReferencePlugin({
 			context: path.join(__dirname, "..", "dll"),
-			manifest: require("../dll/js/alpha-manifest.json")
+			manifest: require("../dll/js/alpha-manifest.json") // eslint-disable-line
 		}),
 		new webpack.DllReferencePlugin({
 			scope: "beta",
-			manifest: require("../dll/js/beta-manifest.json"),
+			manifest: require("../dll/js/beta-manifest.json"), // eslint-disable-line
 			extensions: [".js", ".jsx"]
 		})
 	]

examples/dll/webpack.config.js

@@ -2,7 +2,7 @@ var path = require("path");
 var webpack = require("../../");
 module.exports = {
 	resolve: {
-		extensions: ['.js', '.jsx']
+		extensions: [".js", ".jsx"]
 	},
 	entry: {
 		alpha: ["./alpha", "./a", "module"],

examples/externals/webpack.config.js

@@ -13,4 +13,4 @@ module.exports = {
 			}
 		}
 	]
-}
+};

examples/extra-async-chunk-advanced/webpack.config.js

@@ -1,5 +1,5 @@
-var path = require("path");
 var CommonsChunkPlugin = require("../../lib/optimize/CommonsChunkPlugin");
+
 module.exports = {
 	plugins: [
 		new CommonsChunkPlugin({
@@ -15,4 +15,4 @@ module.exports = {
 			async: true
 		}),
 	]
-}
+};

examples/extra-async-chunk/webpack.config.js

@@ -1,5 +1,5 @@
-var path = require("path");
 var CommonsChunkPlugin = require("../../lib/optimize/CommonsChunkPlugin");
+
 module.exports = {
 	plugins: [
 		new CommonsChunkPlugin({
@@ -11,4 +11,4 @@ module.exports = {
 			async: true
 		})
 	]
-}
+};

examples/hybrid-routing/webpack.config.js

@@ -11,7 +11,7 @@ module.exports = {
 	},
 	output: {
 		path: path.join(__dirname, "js"),
-		publicPath: 'js/',
+		publicPath: "js/",
 		filename: "[name].bundle.js",
 		chunkFilename: "[id].chunk.js"
 	},
@@ -24,4 +24,4 @@ module.exports = {
 		})
 		// The pages cannot run without the commons.js file now.
 	]
-}
+};

examples/i18n/webpack.config.js

@@ -18,4 +18,4 @@ module.exports = Object.keys(languages).map(function(language) {
 			)
 		]
 	};
-});
+});

examples/move-to-parent/webpack.config.js

@@ -36,4 +36,4 @@ module.exports = {
 			}
 		})
 	]
-}
+};

examples/multi-compiler/webpack.config.js

@@ -27,4 +27,4 @@ module.exports = [
 			})
 		]
 	}
-];
+];

examples/multi-part-library/webpack.config.js

@@ -10,4 +10,4 @@ module.exports = {
 		library: ["MyLibrary", "[name]"],
 		libraryTarget: "umd"
 	}
-}
+};

examples/multiple-commons-chunks/webpack.config.js

@@ -28,4 +28,4 @@ module.exports = {
 			chunks: ["pageC", "adminPageC"]
 		}),
 	]
-}
+};

examples/multiple-entry-points-commons-chunk-css-bundle/webpack.config.js

@@ -33,4 +33,4 @@ module.exports = {
 			filename: "[name].css"
 		}),
 	]
-};
+};

examples/multiple-entry-points/webpack.config.js

@@ -16,4 +16,4 @@ module.exports = {
 			name: "commons"
 		})
 	]
-}
+};

examples/two-explicit-vendor-chunks/webpack.config.js

@@ -18,4 +18,4 @@ module.exports = {
 			minChunks: Infinity
 		})
 	]
-}
+};

examples/web-worker/webpack.config.js

@@ -12,4 +12,4 @@ module.exports = {
 			}
 		})
 	]
-}
+};

hot/log-apply-result.js

@@ -25,6 +25,6 @@ module.exports = function(updatedModules, renewedModules) {
 			return typeof moduleId === "number";
 		});
 		if(numberIds)
-			console.log("[HMR] Consider using the NamedModulesPlugin for module names.")
+			console.log("[HMR] Consider using the NamedModulesPlugin for module names.");
 	}
 };

hot/poll.js

@@ -26,7 +26,7 @@ if(module.hot) {
 				}
 			});
 		}
-	}
+	};
 	setInterval(checkForUpdate, hotPollInterval);
 } else {
 	throw new Error("[HMR] Hot Module Replacement is disabled.");

hot/signal.js

@@ -34,7 +34,7 @@ if(module.hot) {
 				console.warn("[HMR] Update failed: " + err.stack || err.message);
 			}
 		});
-	}
+	};
 
 	process.on(__resourceQuery.substr(1) || "SIGUSR2", function() {
 		if(module.hot.status() !== "idle") {

lib/CaseSensitiveModulesWarning.js

@@ -40,4 +40,4 @@ module.exports = class CaseSensitiveModulesWarning extends Error {
 			return message;
 		}).join("\n");
 	}
-}
+};

lib/Chunk.js

@@ -12,7 +12,7 @@ const byId = (a, b) => {
 	if(a.id < b.id) return -1;
 	if(b.id < a.id) return 1;
 	return 0;
-}
+};
 
 class Chunk {
 
@@ -183,7 +183,7 @@ class Chunk {
 				}
 				onChunk(c);
 			});
-		}
+		};
 		moveChunks(other.parents, "chunks", c => {
 			if(c !== this && this.addParent(c)) {
 				c.addChunk(this);

lib/Compiler.js

@@ -187,7 +187,7 @@ function Compiler() {
 				});
 			});
 		}.bind(this)
-	}
+	};
 
 	this.options = {};
 }

lib/ConstPlugin.js

@@ -11,7 +11,7 @@ const NullFactory = require("./NullFactory");
 const getQuery = (request) => {
 	const i = request.indexOf("?");
 	return request.indexOf("?") < 0 ? "" : request.substr(i);
-}
+};
 
 class ConstPlugin {
 	apply(compiler) {

lib/ContextModule.js

@@ -77,7 +77,7 @@ ContextModule.prototype.libIdent = function(options) {
 	if(this.addon)
 		identifier += contextify(options, this.addon);
 	if(this.regExp)
-		identifier += prettyRegExp(this.regExp + "")
+		identifier += prettyRegExp(this.regExp + "");
 	return identifier.replace(/ $/, "");
 };
 

lib/ContextModuleFactory.js

@@ -73,8 +73,8 @@ ContextModuleFactory.prototype.create = function(data, callback) {
 					resolvers.loader.resolve({}, context, loader, function(err, result) {
 						if(err) return callback(err);
 						callback(null, result);
-					})
-				}, callback)
+					});
+				}, callback);
 			}
 		], function(err, result) {
 			if(err) return callback(err);

lib/ContextReplacementPlugin.js

@@ -12,7 +12,7 @@ function ContextReplacementPlugin(resourceRegExp, newContentResource, newContent
 	} else if(typeof newContentResource === "string" && typeof newContentRecursive === "object") {
 		this.newContentResource = newContentResource;
 		this.newContentCreateContextMap = function(fs, callback) {
-			callback(null, newContentRecursive)
+			callback(null, newContentRecursive);
 		};
 	} else if(typeof newContentResource === "string" && typeof newContentRecursive === "function") {
 		this.newContentResource = newContentResource;
@@ -99,5 +99,5 @@ function createResolveDependenciesFromContextMap(createContextMap) {
 			});
 			callback(null, dependencies);
 		});
-	}
+	};
 }

lib/DelegatedModule.js

@@ -50,7 +50,7 @@ DelegatedModule.prototype.build = function(options, compilation, resolver, fs, c
 DelegatedModule.prototype.unbuild = function() {
 	this.built = false;
 	Module.prototype.unbuild.call(this);
-}
+};
 
 DelegatedModule.prototype.source = function() {
 	var sourceModule = this.dependencies[0].module;

lib/DynamicEntryPlugin.js

@@ -33,7 +33,7 @@ class DynamicEntryPlugin {
 						if(err) return reject(err);
 						resolve();
 					});
-				})
+				});
 			};
 
 			Promise.resolve(this.entry()).then((entry) => {
@@ -44,7 +44,7 @@ class DynamicEntryPlugin {
 						return addEntry(entry[name], name);
 					})).then(() => callback(), callback);
 				}
-			})
+			});
 		});
 	}
 }

lib/EntryOptionPlugin.js

@@ -28,4 +28,4 @@ module.exports = class EntryOptionPlugin {
 			return true;
 		});
 	}
-}
+};

lib/ExternalModuleFactoryPlugin.js

@@ -50,7 +50,7 @@ ExternalModuleFactoryPlugin.prototype.apply = function(normalModuleFactory) {
 								return next();
 							}
 							callback(null, module);
-						}
+						};
 
 						do {
 							var async = true;

lib/FlagDependencyUsagePlugin.js

@@ -13,7 +13,7 @@ FlagDependencyUsagePlugin.prototype.apply = function(compiler) {
 
 			modules.forEach(function(module) {
 				module.used = false;
-			})
+			});
 
 			var queue = [];
 			compilation.chunks.forEach(function(chunk) {