Update ht_phasor & ht_sine method so they accept only one argument

laratrade · Apr 5, 2018 · ce38ad3 · ce38ad3
1 parent 8114bc4
commit ce38ad3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 18 deletions.
diff --git a/src/Contracts/Trader.php b/src/Contracts/Trader.php
@@ -1230,21 +1230,19 @@ public function ht_dcphase(array $real): array;
      * Hilbert Transform - Phasor Components.
      *
      * @param array $open  Opening price, array of real values.
-     * @param array $close Closing price, array of real values.
      *
      * @return array Returns an array with calculated data.
      */
-    public function ht_phasor(array $open, array $close): array;
+    public function ht_phasor(array $open): array;
 
     /**
      * Hilbert Transform - Phasor Components.
      *
      * @param array $open  Opening price, array of real values.
-     * @param array $close Closing price, array of real values.
      *
      * @return array Returns an array with calculated data.
      */
-    public function ht_sine(array $open, array $close): array;
+    public function ht_sine(array $open): array;
 
     /**
      * Hilbert Transform - Instantaneous Trendline.

diff --git a/src/Trader.php b/src/Trader.php
@@ -1838,12 +1838,11 @@ public function ht_dcphase(array $real): array
     /**
      * Hilbert Transform - Phasor Components.
      *
-     * @param array $open  Opening price, array of real values.
-     * @param array $close Closing price, array of real values.
+     * @param array $open Opening price, array of real values.
      *
      * @return array Returns an array with calculated data.
      */
-    public function ht_phasor(array $open, array $close): array
+    public function ht_phasor(array $open): array
     {
         $result = trader_ht_phasor($open, $close);
 
@@ -1856,13 +1855,12 @@ public function ht_phasor(array $open, array $close): array
      * Hilbert Transform - Phasor Components.
      *
      * @param array $open  Opening price, array of real values.
-     * @param array $close Closing price, array of real values.
      *
      * @return array Returns an array with calculated data.
      */
-    public function ht_sine(array $open, array $close): array
+    public function ht_sine(array $open): array
     {
-        $result = trader_ht_sine($open, $close);
+        $result = trader_ht_sine($open);
 
         $this->handleErrors();
 

diff --git a/tests/Unit/TraderTest.php b/tests/Unit/TraderTest.php
@@ -920,22 +920,18 @@ public function it_executes_ht_dcphase_correctly()
     /** @test */
     public function it_executes_ht_phasor_correctly()
     {
-        $inPhase1 = [];
-        $inPhase2 = [];
         $this->assertEquals(
-            trader_ht_phasor(static::$close, $inPhase1),
-            static::$trader->ht_phasor(static::$close, $inPhase2)
+            trader_ht_phasor(static::$close),
+            static::$trader->ht_phasor(static::$close)
         );
     }
 
     /** @test */
     public function it_executes_ht_sine_correctly()
     {
-        $sine1 = [];
-        $sine2 = [];
         $this->assertEquals(
-            trader_ht_sine(static::$close, $sine1),
-            static::$trader->ht_sine(static::$close, $sine2)
+            trader_ht_sine(static::$close),
+            static::$trader->ht_sine(static::$close)
         );
     }