Skip to content

[12.x] Remove the "$" prefix from property names #10662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions events.md
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ class SendShipmentNotification implements ShouldQueue

If one of your queued listeners is encountering an error, you likely do not want it to keep retrying indefinitely. Therefore, Laravel provides various ways to specify how many times or for how long a listener may be attempted.

You may define a `$tries` property on your listener class to specify how many times the listener may be attempted before it is considered to have failed:
You may define a `tries` property on your listener class to specify how many times the listener may be attempted before it is considered to have failed:

```php
<?php
Expand Down Expand Up @@ -682,7 +682,7 @@ In this example, the listener will be retried up to 25 times. However, the liste
<a name="specifying-queued-listener-timeout"></a>
#### Specifying Queued Listener Timeout

Often, you know roughly how long you expect your queued listeners to take. For this reason, Laravel allows you to specify a "timeout" value. If a listener is processing for longer than the number of seconds specified by the timeout value, the worker processing the listener will exit with an error. You may define the maximum number of seconds a listener should be allowed to run by defining a `$timeout` property on your listener class:
Often, you know roughly how long you expect your queued listeners to take. For this reason, Laravel allows you to specify a "timeout" value. If a listener is processing for longer than the number of seconds specified by the timeout value, the worker processing the listener will exit with an error. You may define the maximum number of seconds a listener should be allowed to run by defining a `timeout` property on your listener class:

```php
<?php
Expand All @@ -703,7 +703,7 @@ class SendShipmentNotification implements ShouldQueue
}
```

If you would like to indicate that a listener should be marked as failed on timeout, you may define the `$failOnTimeout` property on the listener class:
If you would like to indicate that a listener should be marked as failed on timeout, you may define the `failOnTimeout` property on the listener class:

```php
<?php
Expand Down