[12.x] Allow limiting number of assets to preload #55618
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preloading a lot of assets, this header can become problematically long. It can cause issues by overflowing the web servers maximum header length or simply be so long that it would be better off not sending it and allowing the html preload tags to kick in.
That isn't to say preloading via this header isn't a good default; it is. This is only for those applications that have an extreme number of assets that are to be preloaded by Vite.
This PR ensures you can limit the number of assets to preload to give some control over the header length.
If we merge this PR I will roll out a sensible default to our packages.