Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless attributes on app-logo component #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rattone
Copy link
Contributor

@Rattone Rattone commented Feb 25, 2025

The app-logo component has no merge attributes or props for href and class

@Rattone Rattone changed the title Remove useless classes on app-logo component Remove useless attributes on app-logo component Feb 26, 2025
Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Down the road I would like to make the app-logo component be a full SVG and pass the attributes to it. This way you could have something like:

<x-app-logo class="h-8 w-auto" />

and if you needed a larger logo we could add something like:

<x-app-logo class="h-20 w-auto" />

But for now, the way that it's built does not have attributes passed to it, so I can approve this.

Thanks!

@tnylea tnylea added the Approved Approved for Merge label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved for Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants